mirror of
https://git.joinsharkey.org/Sharkey/Sharkey.git
synced 2025-04-07 04:21:35 +03:00
d792f4f348
* fix(backend): `text: null`だけのノートは投稿できないように * add test * Update CHANGELOG.md * chore: bump OpenAPI Specification from 3.0.0 to 3.1.0 * chore: テストがすでにコメントで記述されていたのでそっちを使うことにする * fix test * fix(backend): prohibit posting whitespace-only notes * Update CHANGELOG.md * fix(backend): `renoteId`または`fileIds`（`mediaIds`）または`poll`が`null`でない場合に、`text が空白文字のみで構成されたリクエストになることを許可して、結果は`text: null`を返すように * test(backend): 引用renoteで空白文字のみで構成されたtextにするとレスポンスが`text: null`になることをチェックするテストを追加 * fix(frontend): `text`が`null`であって`renoteId`と`replyId`が`null`でないようなノートは引用リノートとして表示するように * fix(misskey-js): OpenAPI 3.1に対応 * fix(misskey-js): 型生成をOpenAPI Specification 3.1.0に対応 * fix(ci): `validate-api.json`をOpenAPI Specification 3.1.0に対応 * fix(ci): スキーマ書き換えの際のミスを修正 * Revert "fix(frontend): `text`が`null`であって`renoteId`と`replyId`が`null`でないようなノートは引用リノートとして表示するように" This reverts commit a9ca55343df6ea1679599acbc4801f78aa3a242b. * fix(misskey-js): `build-misskey-js-with-types`時は`api.json`のGETをスキップするように * Revert "fix(misskey-js): `build-misskey-js-with-types`時は`api.json`のGETをスキップするように" This reverts commit 865458989f9ddacc38d1bb3743a41ea828dbf324. * fix(misskey-js): `openapi-parser`で`validate`のかわりに`parse`を用いるように * Update CHANGELOG.md
370 lines
11 KiB
TypeScript
370 lines
11 KiB
TypeScript
/*
|
||
* SPDX-FileCopyrightText: syuilo and other misskey contributors
|
||
* SPDX-License-Identifier: AGPL-3.0-only
|
||
*/
|
||
|
||
import ms from 'ms';
|
||
import { In } from 'typeorm';
|
||
import { Inject, Injectable } from '@nestjs/common';
|
||
import type { MiUser } from '@/models/User.js';
|
||
import type { UsersRepository, NotesRepository, BlockingsRepository, DriveFilesRepository, ChannelsRepository } from '@/models/_.js';
|
||
import type { MiDriveFile } from '@/models/DriveFile.js';
|
||
import type { MiNote } from '@/models/Note.js';
|
||
import type { MiChannel } from '@/models/Channel.js';
|
||
import { MAX_NOTE_TEXT_LENGTH } from '@/const.js';
|
||
import { Endpoint } from '@/server/api/endpoint-base.js';
|
||
import { NoteEntityService } from '@/core/entities/NoteEntityService.js';
|
||
import { NoteCreateService } from '@/core/NoteCreateService.js';
|
||
import { DI } from '@/di-symbols.js';
|
||
import { isPureRenote } from '@/misc/is-pure-renote.js';
|
||
import { ApiError } from '../../error.js';
|
||
|
||
export const meta = {
|
||
tags: ['notes'],
|
||
|
||
requireCredential: true,
|
||
|
||
prohibitMoved: true,
|
||
|
||
limit: {
|
||
duration: ms('1hour'),
|
||
max: 300,
|
||
},
|
||
|
||
kind: 'write:notes',
|
||
|
||
res: {
|
||
type: 'object',
|
||
optional: false, nullable: false,
|
||
properties: {
|
||
createdNote: {
|
||
type: 'object',
|
||
optional: false, nullable: false,
|
||
ref: 'Note',
|
||
},
|
||
},
|
||
},
|
||
|
||
errors: {
|
||
noSuchRenoteTarget: {
|
||
message: 'No such renote target.',
|
||
code: 'NO_SUCH_RENOTE_TARGET',
|
||
id: 'b5c90186-4ab0-49c8-9bba-a1f76c282ba4',
|
||
},
|
||
|
||
cannotReRenote: {
|
||
message: 'You can not Renote a pure Renote.',
|
||
code: 'CANNOT_RENOTE_TO_A_PURE_RENOTE',
|
||
id: 'fd4cc33e-2a37-48dd-99cc-9b806eb2031a',
|
||
},
|
||
|
||
cannotRenoteDueToVisibility: {
|
||
message: 'You can not Renote due to target visibility.',
|
||
code: 'CANNOT_RENOTE_DUE_TO_VISIBILITY',
|
||
id: 'be9529e9-fe72-4de0-ae43-0b363c4938af',
|
||
},
|
||
|
||
noSuchReplyTarget: {
|
||
message: 'No such reply target.',
|
||
code: 'NO_SUCH_REPLY_TARGET',
|
||
id: '749ee0f6-d3da-459a-bf02-282e2da4292c',
|
||
},
|
||
|
||
cannotReplyToInvisibleNote: {
|
||
message: 'You cannot reply to an invisible Note.',
|
||
code: 'CANNOT_REPLY_TO_AN_INVISIBLE_NOTE',
|
||
id: 'b98980fa-3780-406c-a935-b6d0eeee10d1',
|
||
},
|
||
|
||
cannotReplyToPureRenote: {
|
||
message: 'You can not reply to a pure Renote.',
|
||
code: 'CANNOT_REPLY_TO_A_PURE_RENOTE',
|
||
id: '3ac74a84-8fd5-4bb0-870f-01804f82ce15',
|
||
},
|
||
|
||
cannotCreateAlreadyExpiredPoll: {
|
||
message: 'Poll is already expired.',
|
||
code: 'CANNOT_CREATE_ALREADY_EXPIRED_POLL',
|
||
id: '04da457d-b083-4055-9082-955525eda5a5',
|
||
},
|
||
|
||
noSuchChannel: {
|
||
message: 'No such channel.',
|
||
code: 'NO_SUCH_CHANNEL',
|
||
id: 'b1653923-5453-4edc-b786-7c4f39bb0bbb',
|
||
},
|
||
|
||
youHaveBeenBlocked: {
|
||
message: 'You have been blocked by this user.',
|
||
code: 'YOU_HAVE_BEEN_BLOCKED',
|
||
id: 'b390d7e1-8a5e-46ed-b625-06271cafd3d3',
|
||
},
|
||
|
||
noSuchFile: {
|
||
message: 'Some files are not found.',
|
||
code: 'NO_SUCH_FILE',
|
||
id: 'b6992544-63e7-67f0-fa7f-32444b1b5306',
|
||
},
|
||
|
||
cannotRenoteOutsideOfChannel: {
|
||
message: 'Cannot renote outside of channel.',
|
||
code: 'CANNOT_RENOTE_OUTSIDE_OF_CHANNEL',
|
||
id: '33510210-8452-094c-6227-4a6c05d99f00',
|
||
},
|
||
},
|
||
} as const;
|
||
|
||
export const paramDef = {
|
||
type: 'object',
|
||
properties: {
|
||
visibility: { type: 'string', enum: ['public', 'home', 'followers', 'specified'], default: 'public' },
|
||
visibleUserIds: { type: 'array', uniqueItems: true, items: {
|
||
type: 'string', format: 'misskey:id',
|
||
} },
|
||
cw: { type: 'string', nullable: true, minLength: 1, maxLength: 100 },
|
||
localOnly: { type: 'boolean', default: false },
|
||
reactionAcceptance: { type: 'string', nullable: true, enum: [null, 'likeOnly', 'likeOnlyForRemote', 'nonSensitiveOnly', 'nonSensitiveOnlyForLocalLikeOnlyForRemote'], default: null },
|
||
noExtractMentions: { type: 'boolean', default: false },
|
||
noExtractHashtags: { type: 'boolean', default: false },
|
||
noExtractEmojis: { type: 'boolean', default: false },
|
||
replyId: { type: 'string', format: 'misskey:id', nullable: true },
|
||
renoteId: { type: 'string', format: 'misskey:id', nullable: true },
|
||
channelId: { type: 'string', format: 'misskey:id', nullable: true },
|
||
|
||
// anyOf内にバリデーションを書いても最初の一つしかチェックされない
|
||
// See https://github.com/misskey-dev/misskey/pull/10082
|
||
text: {
|
||
type: 'string',
|
||
minLength: 1,
|
||
maxLength: MAX_NOTE_TEXT_LENGTH,
|
||
nullable: true,
|
||
},
|
||
fileIds: {
|
||
type: 'array',
|
||
uniqueItems: true,
|
||
minItems: 1,
|
||
maxItems: 16,
|
||
items: { type: 'string', format: 'misskey:id' },
|
||
},
|
||
mediaIds: {
|
||
type: 'array',
|
||
uniqueItems: true,
|
||
minItems: 1,
|
||
maxItems: 16,
|
||
items: { type: 'string', format: 'misskey:id' },
|
||
},
|
||
poll: {
|
||
type: 'object',
|
||
nullable: true,
|
||
properties: {
|
||
choices: {
|
||
type: 'array',
|
||
uniqueItems: true,
|
||
minItems: 2,
|
||
maxItems: 10,
|
||
items: { type: 'string', minLength: 1, maxLength: 50 },
|
||
},
|
||
multiple: { type: 'boolean' },
|
||
expiresAt: { type: 'integer', nullable: true },
|
||
expiredAfter: { type: 'integer', nullable: true, minimum: 1 },
|
||
},
|
||
required: ['choices'],
|
||
},
|
||
},
|
||
// (re)note with text, files and poll are optional
|
||
if: {
|
||
properties: {
|
||
renoteId: {
|
||
type: 'null',
|
||
},
|
||
fileIds: {
|
||
type: 'null',
|
||
},
|
||
mediaIds: {
|
||
type: 'null',
|
||
},
|
||
poll: {
|
||
type: 'null',
|
||
},
|
||
},
|
||
},
|
||
then: {
|
||
properties: {
|
||
text: {
|
||
type: 'string',
|
||
minLength: 1,
|
||
maxLength: MAX_NOTE_TEXT_LENGTH,
|
||
pattern: '[^\\s]+',
|
||
},
|
||
},
|
||
required: ['text'],
|
||
},
|
||
} as const;
|
||
|
||
@Injectable()
|
||
export default class extends Endpoint<typeof meta, typeof paramDef> { // eslint-disable-line import/no-default-export
|
||
constructor(
|
||
@Inject(DI.usersRepository)
|
||
private usersRepository: UsersRepository,
|
||
|
||
@Inject(DI.notesRepository)
|
||
private notesRepository: NotesRepository,
|
||
|
||
@Inject(DI.blockingsRepository)
|
||
private blockingsRepository: BlockingsRepository,
|
||
|
||
@Inject(DI.driveFilesRepository)
|
||
private driveFilesRepository: DriveFilesRepository,
|
||
|
||
@Inject(DI.channelsRepository)
|
||
private channelsRepository: ChannelsRepository,
|
||
|
||
private noteEntityService: NoteEntityService,
|
||
private noteCreateService: NoteCreateService,
|
||
) {
|
||
super(meta, paramDef, async (ps, me) => {
|
||
let visibleUsers: MiUser[] = [];
|
||
if (ps.visibleUserIds) {
|
||
visibleUsers = await this.usersRepository.findBy({
|
||
id: In(ps.visibleUserIds),
|
||
});
|
||
}
|
||
|
||
let files: MiDriveFile[] = [];
|
||
const fileIds = ps.fileIds ?? ps.mediaIds ?? null;
|
||
if (fileIds != null) {
|
||
files = await this.driveFilesRepository.createQueryBuilder('file')
|
||
.where('file.userId = :userId AND file.id IN (:...fileIds)', {
|
||
userId: me.id,
|
||
fileIds,
|
||
})
|
||
.orderBy('array_position(ARRAY[:...fileIds], "id"::text)')
|
||
.setParameters({ fileIds })
|
||
.getMany();
|
||
|
||
if (files.length !== fileIds.length) {
|
||
throw new ApiError(meta.errors.noSuchFile);
|
||
}
|
||
}
|
||
|
||
let renote: MiNote | null = null;
|
||
if (ps.renoteId != null) {
|
||
// Fetch renote to note
|
||
renote = await this.notesRepository.findOneBy({ id: ps.renoteId });
|
||
|
||
if (renote == null) {
|
||
throw new ApiError(meta.errors.noSuchRenoteTarget);
|
||
} else if (isPureRenote(renote)) {
|
||
throw new ApiError(meta.errors.cannotReRenote);
|
||
}
|
||
|
||
// Check blocking
|
||
if (renote.userId !== me.id) {
|
||
const blockExist = await this.blockingsRepository.exist({
|
||
where: {
|
||
blockerId: renote.userId,
|
||
blockeeId: me.id,
|
||
},
|
||
});
|
||
if (blockExist) {
|
||
throw new ApiError(meta.errors.youHaveBeenBlocked);
|
||
}
|
||
}
|
||
|
||
if (renote.visibility === 'followers' && renote.userId !== me.id) {
|
||
// 他人のfollowers noteはreject
|
||
throw new ApiError(meta.errors.cannotRenoteDueToVisibility);
|
||
} else if (renote.visibility === 'specified') {
|
||
// specified / direct noteはreject
|
||
throw new ApiError(meta.errors.cannotRenoteDueToVisibility);
|
||
}
|
||
|
||
if (renote.channelId && renote.channelId !== ps.channelId) {
|
||
// チャンネルのノートに対しリノート要求がきたとき、チャンネル外へのリノート可否をチェック
|
||
// リノートのユースケースのうち、チャンネル内→チャンネル外は少数だと考えられるため、JOINはせず必要な時に都度取得する
|
||
const renoteChannel = await this.channelsRepository.findOneBy({ id: renote.channelId });
|
||
if (renoteChannel == null) {
|
||
// リノートしたいノートが書き込まれているチャンネルが無い
|
||
throw new ApiError(meta.errors.noSuchChannel);
|
||
} else if (!renoteChannel.allowRenoteToExternal) {
|
||
// リノート作成のリクエストだが、対象チャンネルがリノート禁止だった場合
|
||
throw new ApiError(meta.errors.cannotRenoteOutsideOfChannel);
|
||
}
|
||
}
|
||
}
|
||
|
||
let reply: MiNote | null = null;
|
||
if (ps.replyId != null) {
|
||
// Fetch reply
|
||
reply = await this.notesRepository.findOneBy({ id: ps.replyId });
|
||
|
||
if (reply == null) {
|
||
throw new ApiError(meta.errors.noSuchReplyTarget);
|
||
} else if (isPureRenote(reply)) {
|
||
throw new ApiError(meta.errors.cannotReplyToPureRenote);
|
||
} else if (!await this.noteEntityService.isVisibleForMe(reply, me.id)) {
|
||
throw new ApiError(meta.errors.cannotReplyToInvisibleNote);
|
||
}
|
||
|
||
// Check blocking
|
||
if (reply.userId !== me.id) {
|
||
const blockExist = await this.blockingsRepository.exist({
|
||
where: {
|
||
blockerId: reply.userId,
|
||
blockeeId: me.id,
|
||
},
|
||
});
|
||
if (blockExist) {
|
||
throw new ApiError(meta.errors.youHaveBeenBlocked);
|
||
}
|
||
}
|
||
}
|
||
|
||
if (ps.poll) {
|
||
if (typeof ps.poll.expiresAt === 'number') {
|
||
if (ps.poll.expiresAt < Date.now()) {
|
||
throw new ApiError(meta.errors.cannotCreateAlreadyExpiredPoll);
|
||
}
|
||
} else if (typeof ps.poll.expiredAfter === 'number') {
|
||
ps.poll.expiresAt = Date.now() + ps.poll.expiredAfter;
|
||
}
|
||
}
|
||
|
||
let channel: MiChannel | null = null;
|
||
if (ps.channelId != null) {
|
||
channel = await this.channelsRepository.findOneBy({ id: ps.channelId, isArchived: false });
|
||
|
||
if (channel == null) {
|
||
throw new ApiError(meta.errors.noSuchChannel);
|
||
}
|
||
}
|
||
|
||
// 投稿を作成
|
||
const note = await this.noteCreateService.create(me, {
|
||
createdAt: new Date(),
|
||
files: files,
|
||
poll: ps.poll ? {
|
||
choices: ps.poll.choices,
|
||
multiple: ps.poll.multiple ?? false,
|
||
expiresAt: ps.poll.expiresAt ? new Date(ps.poll.expiresAt) : null,
|
||
} : undefined,
|
||
text: ps.text ?? undefined,
|
||
reply,
|
||
renote,
|
||
cw: ps.cw,
|
||
localOnly: ps.localOnly,
|
||
reactionAcceptance: ps.reactionAcceptance,
|
||
visibility: ps.visibility,
|
||
visibleUsers,
|
||
channel,
|
||
apMentions: ps.noExtractMentions ? [] : undefined,
|
||
apHashtags: ps.noExtractHashtags ? [] : undefined,
|
||
apEmojis: ps.noExtractEmojis ? [] : undefined,
|
||
});
|
||
|
||
return {
|
||
createdNote: await this.noteEntityService.pack(note, me),
|
||
};
|
||
});
|
||
}
|
||
}
|