graphite/Sharkey
1
0
Fork 0
mirror of https://git.joinsharkey.org/Sharkey/Sharkey.git synced 2024-12-02 16:23:08 +02:00
Code Issues Projects Releases Packages Wiki Activity

Refactor: Switch Settings index page to setup sugar (#8374)

Browse source 
* refactor(client): Make Settings index page use <script setup>

* chore(client): address review comments
This commit is contained in:
Andreas Nedbal 2022-03-06 11:17:43 +01:00 committed by GitHub
parent 2442592ef1
commit 939773a5b9
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 209 additions and 231 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

36
packages/client/src/pages/settings/index.vue
View file

@ -22,8 +22,8 @@
</MkSpacer> </MkSpacer>
</template> </template>
<script lang="ts"> <script setup lang="ts">
import { computed, defineAsyncComponent, defineComponent, nextTick, onMounted, reactive, ref, watch } from 'vue'; import { computed, defineAsyncComponent, nextTick, onMounted, ref, watch } from 'vue';
import { i18n } from '@/i18n'; import { i18n } from '@/i18n';
import MkInfo from '@/components/ui/info.vue'; import MkInfo from '@/components/ui/info.vue';
import MkSuperMenu from '@/components/ui/super-menu.vue'; import MkSuperMenu from '@/components/ui/super-menu.vue';
@ -34,20 +34,10 @@ import * as symbols from '@/symbols';
import { instance } from '@/instance'; import { instance } from '@/instance';
import { $i } from '@/account'; import { $i } from '@/account';
export default defineComponent({ const props = defineProps<{
components: { initialPage?: string
MkInfo, }>();
MkSuperMenu,
},
props: {
initialPage: {
type: String,
required: false
}
},
setup(props, context) {
const indexInfo = { const indexInfo = {
title: i18n.ts.settings, title: i18n.ts.settings,
icon: 'fas fa-cog', icon: 'fas fa-cog',
@ -58,7 +48,7 @@ export default defineComponent({
const page = ref(props.initialPage); const page = ref(props.initialPage);
const narrow = ref(false); const narrow = ref(false);
const view = ref(null); const view = ref(null);
const el = ref(null); const el = ref<HTMLElement | null>(null);
const childInfo = ref(null); const childInfo = ref(null);
const menuDef = computed(() => [{ const menuDef = computed(() => [{
title: i18n.ts.basicSettings, title: i18n.ts.basicSettings,
@ -255,20 +245,8 @@ export default defineComponent({
childInfo.value = page[symbols.PAGE_INFO]; childInfo.value = page[symbols.PAGE_INFO];
}; };
return { defineExpose({
[symbols.PAGE_INFO]: INFO, [symbols.PAGE_INFO]: INFO,
page,
menuDef,
narrow,
view,
el,
pageProps,
component,
emailNotConfigured,
pageChanged,
childInfo,
};
},
}); });
</script> </script>